-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Templatize spreadinterp and more cleanups #567
base: master
Are you sure you want to change the base?
Conversation
There are now no more doubly-compiled sources in the library (there are still doubly-compiled tests however). The current state is not pretty, since I had to make a few compromises to arrive at this point, but from now on things should improve again. |
Current test failures seem to be related to network problems on the CI servers ... they failed to download FFTW. |
OK, I'll stop myself here and wait for the review. Don't get me wrong: there is still much to be done to really gather the benefits of this restructuring ... but all these subsequent changes will be more or less localized, and they will be much more fun than it was getting to the current state. My hope would be that this can be merged before any other of the open PRs, because incorporating any change on master into this PR will be extremely painful. Of course I'll be happy to help with adjusting the conflicts I cause in the other PRs! |
This is a massive change to
spreadinterp.cpp
, both reordering the functions in the file to avoid forward declarations, and templatizing everything in there.I'd be happy to get this in as soon as possible, but I appreciate that this will be very hard to review...